From ede75738ea2bb04fc55b6cd8ea18b640bd41ba6e Mon Sep 17 00:00:00 2001 From: Charles Pigott Date: Sat, 1 Nov 2014 12:36:05 +0000 Subject: [PATCH 5/6] -Codechange: No need to directly use char arrays for the caption. --- src/video.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/video.cpp b/src/video.cpp index 66d8c69..fb492c1 100644 --- a/src/video.cpp +++ b/src/video.cpp @@ -155,9 +155,9 @@ std::string VideoSystem::Initialize(const char *font_name, int font_size) return err; } - char caption[50]; - snprintf(caption, sizeof(caption), "FreeRCT %s", _freerct_revision); - this->window = SDL_CreateWindow(caption, SDL_WINDOWPOS_CENTERED, SDL_WINDOWPOS_CENTERED, 800, 600, SDL_WINDOW_RESIZABLE); + std::string caption = "FreeRCT "; + caption += _freerct_revision; + this->window = SDL_CreateWindow(caption.c_str(), SDL_WINDOWPOS_CENTERED, SDL_WINDOWPOS_CENTERED, 800, 600, SDL_WINDOW_RESIZABLE); if (this->window == nullptr) { std::string err = "SDL window creation failed: "; err += SDL_GetError(); -- 2.1.3